MMPY-410 - Remove holds for account and tax information

- source :: https://multimediallc.atlassian.net/browse/MMPY-410

- tags :: Falcon Nest Project Story Falcon Nest Project

- status :: In Review

- epic :: MMPY-179 - Tax ID Validation Workflow

- sprint :: MM Sprint 24

- pull :: https://github.com/multimediallc/mm-pay-internal/pull/429

Tasks

DONE Remove all parts of NO_VALID_ACCOUNT and TAX_INFORMATION_INVALID holds

holdsmultimediallcworkchoremmpy410mmpy179

ID: f5ecc4d6-5dab-d7a7-5f85-29c147e1ae88

DONE Fix all the broken tests from removing the hold logic

holdsmultimediallcworkchoremmpy410mmpy179tests

ID: 9e6e6a75-555d-39f2-2ed8-eab3c958a3e2

DONE Review and address PR issues

holdsmultimediallcworkchoremmpy410mmpy179prreview

ID: e2936074-651e-8b46-072c-3e675f33d972

Background

Currently there are holds for No Valid Payout Account and Tax Information Invalid. These holds are user level, but don’t have a good logic to follow with multiple payees under a user when they have mixed profile setups (good tax, bad account, etc). The essential information is: does the user have one complete profile?

The is_payable lookup will ensure:

not in a “do not pay” status

identity valid (incomplete ticket)

account in good status (complete)

tax information in good status (incomplete ticket) - MMPY-283: Update has_required_payout_information to include valid tax information

Backlog

The has_required_payout_info will ensure the above, but skips the “do not pay” lookup.

The bad_account call will check if there is no payable accounts, only closed payable accounts.

As we move to the future the is_user_payable lookup will account for the above, as well as holds, with some nuance around identity expiration dates. (future ticket for release 2)

The goal of this ticket is to undo the current hold system for tax information and accounts, knowing that we are protected by is_payable and is_user_payable for other function flows.

Requirements

Remove creation and similar workflows for Tax Information and No valid account holds.

The bad_account call will check if there is no payable accounts, only closed payable accounts.

currently this check looks for no valid account holds, we can just look to see if there is at least one account in any state but no open accounts