- ID
- a385f852-7b3f-4186-9d2a-01015d9a16f9
ENG-8468 Strengths form on profile not working properly
- tags :: Jira People Attributes
- source :: https://15five-dev.atlassian.net/browse/ENG-8468
- pull request :: https://github.com/15five/fifteen5/pull/27576
- sentry :: https://sentry.io/organizations/15five/issues/1582679956
Problem
- When users save the CareerVisionForm, they get a 500 error
- Sentry log suggests it's a dict key access issue, where I did not make
provision for the strengths form to be empty when adding disabled to it
Solution
- In the first PR, I just initialize a list for the strengths field and then add
the new values to it IF they exist
- I was able to write a test that failed with out the fix, and passed with the
fix, so that gave me some confidence the situation was fixed
New problem
- Turns out there was a secondary problem with how I modified the form where the
strengths fields were not even added to the form if default attributes didn't
exist. That is fixed in ENG-8503