- ID
- bc039781-e02c-4db6-abce-5568eed4073a
- ROAM_ALIASES
- ENG-14107
ENG-14107 - PeopleAttribute has no visiblity_setting
- tags :: Jira Bugs 15Five Project: People Attributes
- source :: https://15five-dev.atlassian.net/browse/ENG-14107
Personal Notes
From João
For line 63 in [[file:~/src/github.com/15five/fifteen5/ff/mods/attributes/utils/db.py::if is_only_admin_editable is False:][ff.mods.attributes.utils.db]]
#+begin_quote
Just an idea: we could use these conditions to define which preset is going to be used and then just call set_visibility_settings once after all the conditions, passing in the selected preset. It feels a bit more DRY... to me at least :D
#+end_quote