2020-09-24 - Thursday

DONE Journal

CLOSED: Fri Sep 25, 202000:51

- Note taken on Thu Sep 24, 202023:52

Finally got tired of messing around with FreeBSD on my work machine. I put ubuntu back on it, because i don't have time to learn Arch. In the meantime, everything is working wonderfully, though I had to take some time out this evening to get things setup.

Thu Sep 24, 2020

DONE [[id:9a41e0e4-e656-4238-9c9b-2a62d9c7d465][15Five Report]]

CLOSED: Fri Sep 25, 202000:52 SCHEDULED: Fri Sep 25, 2020

ID: 958ebea9-3d8e-4907-828e-32d9b9165224

DONE [[id:ac376401-a8b9-45c5-ab1a-4a77837bd03c][Partnership Squad Engineering Stand-up]]

CLOSED: Thu Sep 24, 202016:20

:LOGBOOK:

CLOCK: Thu Sep 24, 202009:05--Thu Sep 24, 202009:30 => 0:25

:END:

<2020-09-24 Thu 8:30-8:40>

DONE [[id:705f5d73-d2fd-44b6-89c1-f40331718313][One-on-Ones]] with [[id:f0daf986-ba04-4111-b7a2-28054a78e1d9][Mac Macintosh]]

CLOSED: Thu Sep 24, 202016:40

ID: f82d7860-fcfd-11ea-9fe2-e86a64ecc701

Thu Sep 24, 202011:30–12:00

DONE [[id:705f5d73-d2fd-44b6-89c1-f40331718313][One-on-Ones]] with [[id:18d2fab5-b24c-466d-bfe4-c8603e8398d7][Tj Vo]]

CLOSED: Thu Sep 24, 202016:39

Thu Sep 24, 202012:00–12:30

DONE Explore possibility that plus signs in S3 files where spaces were is the issue with [[id:d224b9a1-d0df-415d-aab2-0e0cf01459dc][ENG-12495]]

CLOSED: Fri Sep 25, 202011:52

ID: 4ec429de-9e99-46da-b0fb-5c5632b983b0

- Note taken on Thu Sep 24, 202010:09

Today Eric Hamiter pointed me towards a [[https://stackoverflow.com/questions/44779042/aws-how-to-fix-s3-event-replacing-space-with-sign-in-object-key-names-in-js/48408891#48408891][Stack Overflow question]] which purports to solve an issue with '+' signs in the paths of S3 files. The problem here is that the sftp code did not introduce new ways of handling getting S3 objects from AWS. We use `ff.core.s3` and the `ObjectWrapper` therein to fetch files from S3.

The problem is that the incorrectly coded string for the S3 key is predicated on the key coming through the [[file:/usr/home/powellc/src/github.com/15five/fifteen5/ff/mods/sftp/views.py::class ReceiverView(View):][ReceiverView]] in the `ff.mods.sftp.views` file with a munged key (with + for spaces) and this is demonstrably not happening. Given an S3 creation event (new file put on S3), the function [[file:/usr/home/powellc/src/github.com/15five/fifteen5/ff/mods/sftp/utils.py::def get_key_for_sftp_event(event: dict) -> str:][get_key_for_sftp_event]] just returns the key. There are tests for this, and you can even send junk in to the test via modifying the events.json file and it doesn't cause any errors.