- ID
- e0c08b1d-b2eb-41a7-a92c-b66427fef6c4
2020-05-18 - Monday
Tasks
DONE Check notifications
CLOSED: SCHEDULED:
- LINK
- https://github.com/notifications
DONE Review [[id:abd31776-07d5-4991-b492-281fbf2ad91e][Pull Request]] updates
CLOSED: SCHEDULED:
- LINK
- https://github.com/15five/fifteen5/pulls?utf8=%E2%9C%93&q=is%3Aopen+is%3Apr+label%3Abackend+-reviewed-by%3Apowellc
DONE Check in on [[id:751cf98d-c58a-4113-9959-b5fc957417ab][ENG-9829]] to help [[id:d9ee5617-addc-4db6-8700-8b63e5323c69][Piotr Grzesik]]
CLOSED: SCHEDULED:
DONE Respond to question about how to handle pagination in [[id:a8e12b37-0fa8-49c7-9501-69bdebcb881e][ENG-8347 - Listing People Attributes Field and Data by User via API]]
CLOSED: SCHEDULED:
- Note taken on
Andrii Pleskach was concerned about the stub PeopleAttributeValue entries for
default values (db entry, no value, introspected from the User model). He
suggests either cleaning up the pagination to not use querysets, or to store
the actual User model values in the PAV table. I think I prefer the latter
case, but we’ll see what Andrii thinks.
DONE Reach out to [[id:81f5893c-aed9-4941-9e8d-329b690bd9de][PPP Squad]] about Namely credentials
CLOSED: SCHEDULED:
DONE Make CSV work similar to the `name` field in BambooHR [[id:9b436f4a-6e6f-4404-8615-20aa795b1a44][ENG-8855]]
CLOSED: SCHEDULED:
DONE Fix error propagation in [[id:9b436f4a-6e6f-4404-8615-20aa795b1a44][ENG-8855]] max attributes error
CLOSED: SCHEDULED:
- Note taken on
Long and the short of this issue is that the max attributes warning shows up
for each user. We need it to show up only once.
DONE Start discussion on removing default attribute viewing/editing from public API [[id:a8e12b37-0fa8-49c7-9501-69bdebcb881e][ENG-8347]]
CLOSED: SCHEDULED:
- SLACK
- https://15five.slack.com/archives/GNQHUB7A7/p1589804785004200
#+BEGIN_QUOTE text from slack https://15five.slack.com/archives/GNQHUB7A7/p1589804785004200
colin: Andrii and I were talking this morning about an engineering problem in
PeopleAttributes with the API. Effectively, the display and creation/updating of
PA within the API is made very complicated with respect to default attributes.
Given the complexity, Andrii suggested, "what if we don't show default
attributes in the public API, and also don't allow creating/updating either?"
This would make engineering easier, but even more, makes logical sense.
Adding these to the API will give two places where the "default attribute"
values can be displayed or changed, the User model and the PA model. Most users
of our API already know how to update email or first and last name of a user
using the API. The value prop for default attributes is in the filtering, not
giving people a second way to view and update the same value in the API (and
least that's the logic I'm currently working with :slightly_smiling_face: )The
ask then: Can we remove default attributes from the public API? The work to
remove what we have now shouldn't materially impact delivery of the API, and
#+END_QUOTE
DONE Clean up fixing default attributes with a new ticket
CLOSED: SCHEDULED:
DONE Remove default attributes from public API [[id:a8e12b37-0fa8-49c7-9501-69bdebcb881e][ENG-8347]]
CLOSED: SCHEDULED:
DONE Ensure feature flag is enabled for new companies after merge [[id:a5ef5c09-113e-4721-884e-803e1b4ba22f][ENG-9615]]
CLOSED: SCHEDULED:
Meetings
DONE [[id:7355c5b2-2577-47ce-ace3-c7f7bc26c0f6][Engineering Stand-ups]] with [[id:10b14f49-b275-45f5-b76b-fea159f0a75a][Andrii]]
CLOSED: SCHEDULED: <2020-05-18 Mon 8:00-8:10>
DONE [[id:9e01a22d-a8a8-4e6c-a1a7-c7bc4d891b9b][Admin Gathering]]
CLOSED: SCHEDULED:
- ZOOM
- https://zoom.us/j/8597441264
DONE [[id:349308fe-5321-40a2-b3d5-91298fdd6b5b][Monday Boost]]
CLOSED: SCHEDULED:
- LOCATION
- https://zoom.us/j/647103643
- Note taken on
Gratitude for today: Thankful for all the parties
I am not much of a party person. Pretty introverted. But I am so thankful for
all the times I have had an opportunity to hangout with my favorite people in
a social setting.
DONE [[id:b65e138c-6942-4c26-8c90-48a8b8e808b6][Selectboard meeting]]
CLOSED: SCHEDULED:
- LOCATION
- https://zoom.us/j/2042208848?pwd=SEVuR3pvSlZ6ZHAvNTBKR1pldW45dz09
High fives
- [X] Love the weekly engineering updates in slack, Natalie DeVito
- [X] Thanks for your shared curiosity in FreeBSD Grisha Kostyuk
- [X] Don’t need awards to know our Support Team is out of this world, but nice
to be acknowledged :)