- ID
- 7b3266b0-453e-4be3-882f-a8b43c5ea3ba
ENG-8371 Refactor Group Type for groups list function
- tags :: Jira Group Types Refactoring
- source :: https://15five-dev.atlassian.net/browse/ENG-8371
- pull request :: https://github.com/15five/fifteen5/pull/27482
Tilting at windmills?
- Andrii Pleskach advised Alden Jenkins to work with me to refactor a really
messy function in the `group/utils.py` file. Curiously I wasn't the primary
author (or the author at all) of the function. Yet it was still a fun project.
- Turns out I love a good refactoring.
Flags with crazy input
- There's a flag `show_all_group_types` that is set to true if there's a group
type name sent in to filter on. But it could also be True simply by having
that value sent into the function. So you can force showing all group types,
or have it triggered by your filter.
- I'm not crazy about the design of this logic. But really, it just makes me
want to be better about breaking my own logic up.