Org Web Adapter

pages/mmpy_272_add_removed_by_to_bulk_hold_creation.org

ID
14612d27-6931-4bc7-9960-dfbfa2ad0f47

MMPY-272 Add removed_by to bulk hold creation

- source :: https://multimediallc.atlassian.net/browse/MMPY-272

- epic :: MMPY-198 Compliance Holds, Fraud Holds, and Banned Payees

- tags :: Falcon Nest Project Story Falcon Nest Project

- status :: Status - Complete

- pull :: https://github.com/multimediallc/mm-pay-internal/pull/337

Description

Ensure all locations where a hold can be removed is including a removed_by

field. This was noticed on bulk_update calls to holds, but an exhaustive search

wasn’t completed.

DONE Find all places where holds are created

workfeatureholdsmmpy272multimediallcmmpy198spike
ID
cd87c490-6e09-72c8-6906-6aab14627cf9

DONE Figure out how to get a user in the ApplicationHoldsManager

workfeatureholdsmmpy272multimediallcmmpy198spike
ID
6dd29e9e-5e30-6256-8d16-96f550f57b0b

DONE Add tests for adding an admin source user to holds

workfeatureholdsmmpy272multimediallcmmpy198tests
ID
4b1c9c88-0fd1-ea59-69b1-3a7e006a209c

DONE Clean up any PR issues and merge

workfeatureholdsmmpy272mmpy198multimediallc
ID
e862f3a4-9330-2045-136f-d44f00146371

- Note taken on

Turns out it was failing coverage on a PermissionDenied check because we only have one user-modifiable hold type. Ran into this with the serializer too, and I just need to mock the HoldTypes.user_modifiable() method.

- Note taken on

This was branched from a branch that no longer exists and I need to rebase it.