- ID
- 1224e489-6e12-4dec-a6a8-c3feaf1a29ae
2020-05-19 - Tuesday
Tasks
DONE Review [[id:10b14f49-b275-45f5-b76b-fea159f0a75a][Andrii Pleskach]]’s PR for refactoring notifications [[id:81ea74da-45b9-44a5-ae01-d98360395db3][ENG-6797]]
CLOSED: SCHEDULED:
DONE Open PR for removing default attribute values from the API [[id:7b172c20-c08c-46d0-8264-cb8a04149ea3][ENG-9955]]
CLOSED: SCHEDULED:
DONE Fix http over-logging from daphne.server
CLOSED: SCHEDULED:
- Note taken on
Looking to improve my local development workflow with more useful logging and
such. Today I got rid of HTTP checks in my logging using:
#+BEGIN_SRC python daphne.server
def log_action(self, protocol, action, details):
"""
Dispatches to any registered action logger, if there is one.
"""
# START ----- Don't show media file logs
if (self.path.startswith(self.admin_media_prefix) or self.path == '/favicon.ico' or 'static' in self.path):
return
# END ----- Don't show page requests which have run successfully
if self.action_logger:
self.action_logger(protocol, action, details)
#+END_SRC
DONE Fix tests on [[id:7b172c20-c08c-46d0-8264-cb8a04149ea3][ENG-9955]]
CLOSED: SCHEDULED:
- Note taken on
For some reason the group listing broke when I removed default attributes …
Also, performance tests took a jump up. But not in CircleCI … that’s odd.
DONE See if I can get clever to get custom API into API docs [[id:77be973e-da02-400e-88c6-4adb2965a6a3][ENG-9666]]
CLOSED: SCHEDULED:
- Note taken on
I don’t think it’s possible to injects docs manually into the auto-gen docs.
- Note taken on
Thinking on my run yesterday, I think the best thing we do here is:
1. Store the actual default attributes in values
2. Split the create/list and edit/delete views in half
3. Wrap DRF tools with the functional view implementations
Meetings
DONE Stand-up with [[id:1a25c7bf-7040-4905-9075-2b12948b128f][Admin Squad]]
CLOSED: SCHEDULED: <2020-05-19 Tue 9:00-9:10>
- ZOOM
- https://zoom.us/j/6278640570
- Note taken on
We also ended up doing some Estimation work as well for Admin Squad