- ID
- d0fbda0a-a99f-44b5-9e0f-018778775da9
2020-10-23 - Friday
DONE [#C] Journal
CLOSED:
DONE PR Reviews [1/3]
CLOSED:
+ [X] https://github.com/15five/fifteen5/pull/31600
+ [ ] https://github.com/15five/fifteen5/pull/31573
+ [ ] https://github.com/15five/fifteen5/pull/31600
DONE [#B] Test that Google auth works with `id_token` [[id:df0307cb-0a67-41da-a1c8-4d5943a136bc][ENG-11071]]
CLOSED:
- Note taken on
I noted in the ticket as well, but I think that the code for this already
works via [[file:~/.virtualenvs/ff/lib/python3.8/site-packages/social_core/backends/google.py::elif 'id_token' in self.data: # Client-side workflow][this code block]]
In this case, you can pass anyone of `access_token`, `id_token` or `code` to
that function and it will log you as best it knows how. So I think we really
just need to be testing whether we can pass id_token into the POST data for
the login. Yaroslav Skorokhid said he was using `token_id` so perhaps
he's just inverted the paramter name?
DONE [[id:7b5c0db6-16c7-447c-bd45-ace0f5ae1cdc][Friday Nature Hike]]
CLOSED: