Org Web Adapter

Editing pages/mmpy_175_add_closed_by_field_to_a_hold.org

:PROPERTIES:
:ID:       766c813e-bd88-4f31-82f2-a8464c32b539
:END:
#+title: MMPY-175 Add closed by field to a hold

- source :: https://multimediallc.atlassian.net/browse/MMPY-175
- epic :: [[id:88adb9ec-ab52-4d87-8625-6cf72d01612c][MMPY-198 Compliance Holds, Fraud Holds, and Banned Payees]]
- tags ::  [[id:4b532967-a1d9-45f4-b1f0-9a02ad540ff0][Falcon Nest Project Story]] [[id:7c3bbb4e-d079-42c4-992c-3e76210911f4][Falcon Nest Project]]
- status ::  [[id:4d41d978-e56f-45c1-88d1-e2c76510972e][Status - Complete]]

* Description
Holds were implemented, without sufficient analysis of the workflows surrounding them.  They function as needed: they can be created, they stop transfers from sending if they exist for a user, their “removed” data acts as both a closure and a record of when it was closed.

There is some confusion as to how a note is supposed to behave, what it means, and there are some transparency issues.

Holds will be able to be closed 1) by a logged in user in django admin, 2) by the system as a course of other events, 3) via API by a user in a remote system

* Requirements
** DONE Add closed_by field to a hold that defaults to our system_user :multimediallc:feature:holds:mmpy175:work:
:PROPERTIES:
:ID:       acaee5ea-ea95-b6aa-7ea9-1a547b33cdf2
:END:
** GIVEN

A hold exists for no active account or no tax information

** WHEN

An account is created, and the system removes the hold

** THEN

The system user is recorded as the user who closed/removed the hold and this is visible in django admin
* Requirements
** DONE Ensure closed_by field is autopopulated via the admin :multimediallc:feature:holds:mmpy175:work:
:PROPERTIES:
:ID:       f0734b0a-bb60-65d9-4651-f2025e0010bb
:END:

** GIVEN

A hold exists and is viewable in django admin

** WHEN

A logged in user goes to close the hold by adding a removed at date

** THEN

The user is recorded as the user who closed/removed the hold, and this is visible in django admin