Org Web Adapter

Editing pages/eng_8371.org

:PROPERTIES:
:ID:       7b3266b0-453e-4be3-882f-a8b43c5ea3ba
:END:
#+TITLE: ENG-8371 Refactor Group Type for groups list function

- tags ::  [[id:b71b60df-d439-4aa1-8c2c-265707adf8ec][Jira]] [[id:1fe035dc-3ca7-4b84-9023-9ed8d7df477d][Group Types]] [[id:0ab8c02a-0121-4bfe-ab25-7617a7f0f82f][Refactoring]]
- source :: https://15five-dev.atlassian.net/browse/ENG-8371
- pull request :: https://github.com/15five/fifteen5/pull/27482

* Tilting at windmills?

- [[id:10b14f49-b275-45f5-b76b-fea159f0a75a][Andrii Pleskach]] advised [[id:832663ed-30d3-41e5-a7f7-d4b8cd4ab5b5][Alden Jenkins]] to work with me to refactor a really
  messy function in the `group/utils.py` file. Curiously I wasn't the primary
  author (or the author at all) of the function. Yet it was still a fun project.
- Turns out I love a good refactoring.

* Flags with crazy input

- There's a flag `show_all_group_types` that is set to true if there's a group
  type name sent in to filter on. But it could also be True simply by having
  that value sent into the function. So you can force showing all group types,
  or have it triggered by your filter.
- I'm not crazy about the design of this logic. But really, it just makes me
  want to be better about breaking my own logic up.