Org Web Adapter

Editing journals/2021_01_18.org

:PROPERTIES:
:ID:       78ad134f-05d9-4867-9100-b7e20ecc851e
:END:
#+TITLE: 2021-01-18 - Monday

* Work
** DONE [[id:c53ca5c6-f567-4a20-b5be-b1eb29630659][Pull Requests that need reviews]] - https://github.com/15five/fifteen5/pull/32904/files
CLOSED: [2021-01-18 Mon 23:22]
** DONE Fix failing tests on [[id:f4d3cd8c-503c-4217-b090-97d0b5df00d9][ENG-13866]]
CLOSED: [2021-01-18 Mon 17:29]
- Note taken on [2021-01-18 Mon 13:30]
  This seems to be a problem in dev with no emails going out. The trouble function appears to be [[file:~/src/github.com/15five/fifteen5/ff/mods/notifications/utils.py::def bulk_can_send_notification(users: List\[User\], notif_type: str) -> List\[int\]:][this function on checkin if a user can send email]]
<2021-01-18 Mon>
https://app.circleci.com/pipelines/github/15five/fifteen5/46032/workflows/6aff922a-b2ed-4e58-bb85-8fe8c5a2991e/jobs/281880
** DONE Start filling out my [[id:9a41e0e4-e656-4238-9c9b-2a62d9c7d465][15Five Report]]
CLOSED: [2021-01-18 Mon 13:30]
<2021-01-18 Mon>
** DONE [[id:c53ca5c6-f567-4a20-b5be-b1eb29630659][Pull Requests that need reviews]] - https://github.com/15five/fifteen5/pull/32905
CLOSED: [2021-01-18 Mon 10:49]
** DONE [[id:c53ca5c6-f567-4a20-b5be-b1eb29630659][Pull Requests that need reviews]] - https://github.com/15five/fifteen5/pull/32907
CLOSED: [2021-01-18 Mon 10:49]
** DONE [[id:c53ca5c6-f567-4a20-b5be-b1eb29630659][Pull Requests that need reviews]] - https://github.com/15five/fifteen5/pull/32911
CLOSED: [2021-01-18 Mon 10:49]

** DONE Mark queries up on [[id:f4d3cd8c-503c-4217-b090-97d0b5df00d9][ENG-13866]]
CLOSED: [2021-01-18 Mon 11:22]
<2021-01-18 Mon>
https://app.circleci.com/pipelines/github/15five/fifteen5/46032/workflows/6aff922a-b2ed-4e58-bb85-8fe8c5a2991e/jobs/281881

** DONE Fix bug in  [[id:0e2ab07e-3d9a-419c-bf23-884bfd403a67][ENG-13982]]  where files starting with `test` are not processed
CLOSED: [2021-01-18 Mon 10:25]

PR: https://github.com/15five/fifteen5-terraform-modules/pull/234/files

#+begin_src python :results output
is_csv_extension = True
TEST_FOLDER_PREFIX='test'
file_path = 'sftp/1234234/File.csv'
is_test_folder = False

split_path = file_path.split('/')
# If our split path is less than 3 in length, we have a root file: 'sftp/<id>/test.csv'
if len(split_path) > 3:
    sub_folder_name = split_path[2].lower()  #  e.g. `some` in path above
    print(sub_folder_name)
    # Folder starts with prefix and is not a CSV file
    is_test_folder = sub_folder_name.startswith(TEST_FOLDER_PREFIX)
print(is_test_folder)
#+end_src

#+RESULTS:
: False

<2021-01-18 Mon>
** [[id:057e5fed-549e-4556-a1ea-36bddccafb56][Stand-up meeting with Andrii]]
<2021-01-18 Mon 8:45-9:00>
** [[id:72ce5a19-e162-43f5-942b-fdddc2ba490c][Partnership Squad Gathering]]
<2021-01-18 Mon 10:00-10:30>
** [[id:349308fe-5321-40a2-b3d5-91298fdd6b5b][Monday Boost]]
<2021-01-18 Mon 12:00-12:30>
* Town
** DONE Send out email about Thursday [[id:d4dd073c-0fed-40c1-97a2-450c2e528ba5][Maine 200 Celebration]] reboot meeting
CLOSED: [2021-01-18 Mon 09:41]
<2021-01-18 Mon>
* Personal
** DONE Go for a short run
CLOSED: [2021-01-18 Mon 16:34]
<2021-01-18 Mon>
** DONE Read [[id:45569d5c-067d-4096-bef2-8f5278f27ca6][MLK's Letter From Birmingham Jail]]
CLOSED: [2021-01-18 Mon 13:11]
<2021-01-18 Mon>
* Timeline
- Note taken on [2021-01-18 Mon 22:20]

[[id:f9a1a25f-aecc-493d-97d3-357e1eb25289][Emma Sweet]] made a stuffed duck breast tonight that had a nut and mincemeat filling. It was delicious. [[id:d562cd49-c073-4d5c-bf96-0300568f74e9][Jessica Rollerson]] prepared some quotes from MLK Jr. for the kids us to take turns reading. We then watched a video presentation of the book I am Martin Luther King Jr. that she had access to through the UUA. It was really well done, and [[id:3886952c-5dcd-4969-8699-82ceebddde76][Jane]] seemed to really enjoy it.

After dinner, rather than set in on dishes I started trying to figure out [[id:33310075-357a-4217-bd62-6292765ab204][Celery]] locally again. It had been killing me since leaving work that I couldn't get the celery task to work, so at best I could say I think the response was faster, but I couldn't prove it. Finally, tonight, I figured out that the tasks were all being sent to different queues. So the email sending were being sent to test2 and test5 queues, while celery was processing tasks only from the default queue. I added a fun little hack to my local settings to send all tasks to the default queue and now it's working great.

Even better, I can show that the saving of high fives is tremendously faster now. :smile:
- Note taken on [2021-01-18 Mon 17:22]

I think I may have finally resolved all the tests on the High Five optimization tasks. Whew! Feel like I should celebrate. But perhaps I should just go back to work on the [[id:a5eb8b66-c81d-4516-b368-f67772da5f0f][15Five Jan 2021 Hackathon]]?
- Note taken on [2021-01-18 Mon 16:30]

My run today was a little on the cold side when I started, but as usual for this time of year, I warmed up quickly. After having a terribly week last week with regards to my right hip and thigh being tight and sore, there have been no problems so far this week. Even my left knee which had a little runner's knee thing going on last week seems to have cleared up as well.
- Note taken on [2021-01-18 Mon 14:57]

Just spent the last two hours trying to fix tests in [[id:f4d3cd8c-503c-4217-b090-97d0b5df00d9][ENG-13866]]. Thankfully, with a much clearer head this afternoon I was able to pin-point the issue to the way we check for user notifications. I had pretty just to invent this logic from a few other piecemeal functions to reduce queries and it was, obviously faulty.

I've cleaned it up, but there's one more test that's failing. I'm re-running it now, but I also want to run before the sun goes down. So I think I need to do that rather than keep working on this.
- Note taken on [2021-01-18 Mon 13:09]

Had a nice lunch break with Emma after the slight to [[id:d2fc1f50-b020-4f19-a882-2434f80ca378][Partnership Squad]] during the [[id:349308fe-5321-40a2-b3d5-91298fdd6b5b][Monday Boost]] today. Her observation was that rather than having a few people at the top survey the results of the year and pick the coolest, what if each squad shared their proudest achievement, with a specific tie back to a company objective.

I think I'd be less hurt if the features that were trumpted about had been picked because they were the product leaders for meeting objectives and bringing in revenue. Instead it felt like it was a parade of what's coolest, and that's ripe for injustice because it's so subjective.
- Note taken on [2021-01-18 Mon 12:01]

Before the boost today, I took a little break to eat a slice of pizza and toast.

The gratitude for today is from [[id:0f5193f7-cf54-4f75-b69e-5f6ff9bc149c][Priscilla Zorilla]] and is asking us what's a time when you felt optimism in the face of great adversity. I had a lot of trouble coming up with an idea today ☹

The boost itself today was a sort of R&D year-in-review. We shipped a lot of cool features, but I couldn't help but see that the work [[id:a4d68b71-9b62-45d7-8801-9ee31707c6ff][Company Squad]] did this year didn't even get a call out in the summary, let alone a review of what we built.
- Note taken on [2021-01-18 Mon 11:12]

I ended up having to fix a bug in the logic for the workday test file import fix. Andrii noticed the possibility of an IndexError. It's an unlikely state, but it's not good to leave something like that in code regardless.

I also reviewed a number of [[id:f94825ec-0493-446c-9632-ee579ad6be3b][João]]'s PRs. I avoidied Andrii's for now because it re-writes Newsfeed logic and does some caching refactoring. I need to find some dedicated time for that.
- Note taken on [2021-01-18 Mon 10:30]

Our [[id:72ce5a19-e162-43f5-942b-fdddc2ba490c][Partnership Squad Gathering]] today was fun. Harry asked what's the best time you've had travelling, not necssarily the destination. [[id:d2e86849-bf61-452a-bb4f-9556e43b3204][Myroslav]] talkeda about a road trip in high school when he went to Bulgaria. Andrii did an 8000 km road trip around the nordic countries in a car. I said the trip from Salzburg to Vienna was the best because we got to talk to a woman from Innsbruk who was really friendly.
- Note taken on [2021-01-18 Mon 09:41]

Checking email after my stand-up and I got a little distracted with an email from SDF about a new matrix server. Trying to get signed up and I wound up thinking to install Fractal as an alternative interface to Matrix, but Fractal uses Rust and Flatpak so it's a fucking nightmare trying to get it to build and install. I hate flatpak.

So then I end up with a Qt5 client because it's on apt and then I have to register and ... whew need to take a step back here.
- Note taken on [2021-01-18 Mon 09:15]

I asked [[id:f9a1a25f-aecc-493d-97d3-357e1eb25289][Emma]] to wake me up when she got up today and I was kinda a sack of potatoes :smile: ... turns out I was in the middle of a cycle and rather than wake up, I just wanted to resolve a dream where I was riding a bike through a city in Finland trying to make it to the airport. A lot to unpack there, but the short of it is that I did not wake up till after 8.

Other than that I 'm feeling pretty good this morning. Still no snow outside after the burst of warm air over the weekend. Running yesterday the air felt like spring. One side-effect of the weather, however, is that I found a single oyster mushroom on the logs we inoculated something like 14 months ago! Seems like the logs will still flush, but that they didn't get the right conditions this past fall.

My stand-up with [[id:10b14f49-b275-45f5-b76b-fea159f0a75a][Andrii]] went well. We compared notes about weather. It's cold in Ukraine right now, in the single digits Fahrenheit. We talked a bit about the [[id:a5eb8b66-c81d-4516-b368-f67772da5f0f][15Five Jan 2021 Hackathon]] projects we're working on. Well, I talked about mine and then Andrii asked if I wanted to hear what he was working on. That was a little embarrassing. I think I tend to make our manager conversations one-directional and would like to do a better job.