Org Web Adapter

Editing journals/2020_05_19.org

:PROPERTIES:
:ID:       1224e489-6e12-4dec-a6a8-c3feaf1a29ae
:END:
#+TITLE: 2020-05-19 - Tuesday

* Tasks
** DONE Review [[id:10b14f49-b275-45f5-b76b-fea159f0a75a][Andrii Pleskach]]’s PR for refactoring notifications [[id:81ea74da-45b9-44a5-ae01-d98360395db3][ENG-6797]]
CLOSED: [2020-05-19 Tue 08:43] SCHEDULED: <2020-05-19 Tue>
** DONE Open PR for removing default attribute values from the API [[id:7b172c20-c08c-46d0-8264-cb8a04149ea3][ENG-9955]]
CLOSED: [2020-05-19 Tue 08:50] SCHEDULED: <2020-05-19 Tue>
** DONE Fix http over-logging from daphne.server
CLOSED: [2020-05-19 Tue 10:02] SCHEDULED: <2020-05-19 Tue>
- Note taken on [2020-05-19 Tue 10:01]

Looking to improve my local development workflow with more useful logging and
  such. Today I got rid of HTTP checks in my logging using:

#+BEGIN_SRC python daphne.server
    def log_action(self, protocol, action, details):
        """
        Dispatches to any registered action logger, if there is one.
        """

# START ----- Don't show media file logs
        if (self.path.startswith(self.admin_media_prefix) or self.path == '/favicon.ico' or 'static' in self.path):
            return
        # END ----- Don't show page requests which have run successfully

if self.action_logger:
            self.action_logger(protocol, action, details)
  #+END_SRC
** DONE Fix tests on [[id:7b172c20-c08c-46d0-8264-cb8a04149ea3][ENG-9955]]
CLOSED: [2020-05-19 Tue 15:16] SCHEDULED: <2020-05-19 Tue>
- Note taken on [2020-05-19 Tue 08:50]

For some reason the group listing broke when I removed default attributes …

Also, performance tests took a jump up. But not in CircleCI … that’s odd.
 
** DONE See if I can get clever to get custom API into API docs [[id:77be973e-da02-400e-88c6-4adb2965a6a3][ENG-9666]]
CLOSED: [2020-05-19 Tue 23:36] SCHEDULED: <2020-05-19 Tue>
- Note taken on [2020-05-19 Tue 08:42]

I don’t think it’s possible to injects docs manually into the auto-gen docs.

- Note taken on [2020-05-17 Sun 22:43]

Thinking on my run yesterday, I think the best thing we do here is:

1. Store the actual default attributes in values
  2. Split the create/list and edit/delete views in half
  3. Wrap DRF tools with the functional view implementations

* Meetings
** DONE Stand-up with [[id:1a25c7bf-7040-4905-9075-2b12948b128f][Admin Squad]] :@15five:
CLOSED: [2020-05-19 Tue 09:28] SCHEDULED: <2020-05-19 Tue 9:00-9:10>
:PROPERTIES:
:ZOOM:     https://zoom.us/j/6278640570
:END:
- Note taken on [2020-05-19 Tue 09:28]
  We also ended up doing some [[id:4e62ae1d-3d8b-4928-9714-95234f8c1881][Estimation]] work as well for [[id:1a25c7bf-7040-4905-9075-2b12948b128f][Admin Squad]]