Org Web Adapter

Editing journals/2020_05_06.org

:PROPERTIES:
:ID:       2b6c2fd5-d150-4c51-a3f2-84dedc3efe83
:END:
#+TITLE: 2020-05-06 - Wednesday

* The Goal
- [X] Kick off next sprint @goal
- [ ] Get outside with the kiddos @goal
- [X] Resolve issue with CSV import of attributes @goal
* The Plan
** DONE One-on-one with [[id:10b14f49-b275-45f5-b76b-fea159f0a75a][Andrii]] :@15five:
CLOSED: [2020-05-06 Wed 08:22] SCHEDULED: <2020-05-06 Wed 8:00-8:30>
** DONE Email and communication :@personal:
CLOSED: [2020-05-06 Wed 08:53] SCHEDULED: <2020-05-06 Wed>
- Note taken on [2020-05-06 Wed 08:53]
  I received NO email this morning worth replying to. That’s amazing!
** DONE Discover if there are other issues with [[id:31af422b-6c81-4391-8373-3b4ea083f4b0][ENG-9635]] :@15five:
CLOSED: [2020-05-06 Wed 08:54] SCHEDULED: <2020-05-06 Wed>
- Note taken on [2020-05-06 Wed 08:34]
  From what I could find, the third issue [[id:da4eba71-b5a8-40c0-987e-7e6166e9912a][Evgeniy Shvab]] documented does not seem
  to be a problem unless the first is true. That is, if there are no values for
  a given attribute.

Actually, the problem behavior seems to be that after a null value in an
  attribute column for a given row, we just stop processing attributes.

** DONE [[id:1a25c7bf-7040-4905-9075-2b12948b128f][Administrative Squad]] huddle :@15five:
CLOSED: [2020-05-06 Wed 10:46] SCHEDULED: <2020-05-06 Wed 9:00-09:30>
:PROPERTIES:
:ZOOM:     https://zoom.us/j/8597441264
:END:
** DONE Reivew [[id:9fd1b150-abcd-40a5-9639-e56d4527d54d][Chukwuka Agu]]’s PR for strengths :@15five:
CLOSED: [2020-05-06 Wed 11:23] SCHEDULED: <2020-05-06 Wed>
https://github.com/15five/fifteen5/pull/28383
** DONE Schedule time to meet with [[id:917a2233-b940-4470-a7a2-6c15301504e2][Dianne Frommelt]] with [[id:dc939cd1-b7ef-4318-9324-dbfc838b41b9][Natalie DeVito]] :@15ifve:
CLOSED: [2020-05-06 Wed 11:28] SCHEDULED: <2020-05-06 Wed>

** DONE [[id:c4cbb750-e46d-42be-ab60-c74e5f5f0cd6][Wednesday Boost]] :@15five:
CLOSED: [2020-05-06 Wed 12:32] SCHEDULED: <2020-05-06 Wed 12:00-12:30>
:PROPERTIES:
:ZOOM:     https://zoom.us/j/647103643
:END:
** DONE Sign extra town warrant :@town:
CLOSED: [2020-05-07 Thu 08:43] SCHEDULED: <2020-05-06 Wed>
* The Reality
** DONE Respond to questions about [[id:8d40bb64-d533-4c05-aab5-90b7921d0765][ENG-9694]] :@15five:
CLOSED: [2020-05-06 Wed 11:19]
** DONE Review [[id:f57ec7f4-49fa-44c7-a750-6d0747b54bff][Zoltan Gorbe]]’s PR :@15five:
CLOSED: [2020-05-06 Wed 17:33] SCHEDULED: <2020-05-06 Wed>
https://github.com/15five/fifteen5/pull/28416
** DONE Come up with a new solution for [[id:31af422b-6c81-4391-8373-3b4ea083f4b0][ENG-9635]] :@15five:
CLOSED: [2020-05-06 Wed 17:32] SCHEDULED: <2020-05-06 Wed>
- Note taken on [2020-05-06 Wed 17:32]
  Oh man, that was crzy. I finally sat down and refactored the tests for
  importing custom attributes with CSV and made it much easier to add subtle
  permutations of data. This allowed to find that it was a simple ‘return‘ ->
  ‘continue’ statement in the aggregator of attributes that needed to be changed.
- Note taken on [2020-05-06 Wed 16:27]
  Spent a big chunk of this afternoon writing a test that more accurately
  describes the bug. This also required reformatting the test as it had been
  previously written in a way that made it very hard to adjust the test parameters.

- Note taken on [2020-05-06 Wed 13:01]
  I worked on this a lot on [[file:2020-05-05.org][2020-05-05 - Tuesday]] without a lot to show for it.
  Andrii noted in the PR that we can’t introspect the value of a new [[id:ca1d297e-764f-4c7d-90c7-93f448fee10b][People
  Attributes]] if we don’t have any values, so we can’t create blank attributes.

Then I discovered that it was only partially to blame of the bug. Really
  it’s that if a ROW has a blank value for an attribute it just stops processing
  new values.
** DONE Vacuum the house as part of [[id:c8440e9a-d465-4785-818f-08fd5699e76e][Home Cleaning]] :@home:
CLOSED: [2020-05-06 Wed 17:36] SCHEDULED: <2020-05-06 Wed>
- Note taken on [2020-05-06 Wed 17:36]
  This did not get done over the weekend and things were looking pretty grim.
* General notes
- High fives to give out [4/4]
  - [X] [[id:0fb77692-7773-4c35-99ef-a174a400ef03][High Five]] @ [[id:1714c385-4170-4cfe-9874-5b1ecca49153][Kapil Gupta]] what an awesome presentation on partnerships! Totally inspired by your teams’ work :)
  - [X] [[id:0fb77692-7773-4c35-99ef-a174a400ef03][High Five]] @ [[id:f17d770a-8513-4ed3-a909-b6a35917606c][Robert Enck]] you’re gonna kick butt in PLG. Have fun and we’ll see you when you’ve done what you need to do :)
  - [X] [[id:0fb77692-7773-4c35-99ef-a174a400ef03][High Five]] @ [[id:10b14f49-b275-45f5-b76b-fea159f0a75a][Andrii Pleskach]] thanks for your patience with the People Attributes API. We’re doing things different but it’s for a good reason. Now we just need to document it ;)
  - [X] [[id:0fb77692-7773-4c35-99ef-a174a400ef03][High Five]] @ [[id:dc939cd1-b7ef-4318-9324-dbfc838b41b9][Natalie DeVito]] it’s the simple things done with joy that make life great :), like scheduling a meeting!