Org Web Adapter

Editing hungryroot/jira/be_7028_update_v2_order_skip_logic_to_match_v1.org

:PROPERTIES:
:ID:       7dde582e-3b95-4c9a-8883-237de9be7c61
:END:
#+title: BE-7028 Update V2 order skip logic to match V1

- source :: https://hungryroot.atlassian.net/browse/BE-7028
- tags ::   [[id:3a477c02-e26d-40f7-a719-0aa1cd169dd8][Hungryroot API Project]] 
- epic ::   [[id:86327fb4-0f66-4bc6-9068-c414cea77042][EP-411 Eng Parking Lot]]
- sprint :: [[id:26939bb8-164c-402e-8a6a-6ae8c99d3e59][HR BE Sprint 102]]
- status :: [[id:a0ae5b03-760c-432f-8e3e-ff8c290676d0][Status - Needs QA]]
  
* Tasks
** DONE Review whether this actually needs work :work:project:ep411:be7028:unskip:hungryroot:api:v2:
:PROPERTIES:
:ID:       fc38e14e-d4f1-499a-78e2-729bafe07740
:END:

Related to [[id:e411b65e-d418-47b7-ab98-54894559c53c][BE-6512 Update CX tool to use v2 unskip order endpoint]]
** DONE Open pull request with any changes needed :work:project:ep411:be7028:unskip:hungryroot:api:v2:
:PROPERTIES:
:ID:       787e4d89-e09a-dbff-1555-fb25b7832042
:END:

* Description
After moving the skip order logic in the CX tool to the V2 endpoint in
https://hungryroot.atlassian.net/browse/BE-6512, some discrepancies were
discovered between the V1 and V2 logic. [[id:4c7af042-1e2a-4b63-b340-506aeba6377a][Ellen Reed]] those differences are:

v2 does not validate whether order is past cutoff and therefore unskippable
calculate preferred date gets a schedule but schedule could be past cutoff;
preferred_date validation just checks if it's valid for the zipcode

I think our UI in both the CX tool and web/mobile hide the "unskip" button if
it's past cutoff, but people can likely still unskip if they're on a stale page.
The API should validate that the order is not past cutoff.

V1 logs a DatadogMetric for ORDER_UNSKIP. I don't know if we still use those, so
this might be fine

V2 hard codes is_cx_action = False. Unless you know they no longer use this
attribute, my understanding is that they use this in Braze to email the customer
about the status change but only if it originated from CX

Ref: https://github.com/hungryroot/hungryroot/pull/12983/changes#r2723012787

Acceptance Criteria

When an order status is changed to unskipped by a PATCH to the V2 order detail
endpoint an error should be returned if the order is past cutoff
(order.is_editable == False)

The V2 endpoint should accept a GET parameter is_cx_action boolean rather than
using a default False value. This is already passed to braze events in the view.